Fix host crash behavior #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed a bug where moving a `TcpListener` into a spawned task was not dropped after crash returns. If you bounce the host, it would error with `ErrorKind::AddrInUse`. Now we also drop and replace the runtime, which has the desired effect of blocking the calling thread until all tasks have dropped, cleaning up all resources.
LucioFranco
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed a bug where moving a
TcpListenerinto a spawned taskwas not dropped after crash returns. If you bounce the host, it would
error with
ErrorKind::AddrInUse.Now we also drop and replace the runtime, which has the desired
effect of blocking the calling thread until all tasks have dropped,
cleaning up all resources.