implement TcpStream::peek methods #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor `StreamSocket` by replacing the channel with a buffer of segments, along with a slot for a waker. `StreamSocket` exposes 2 methods: `poll_read_ready` and `try_read` mimicking tokio in both API and behavior.
LucioFranco
reviewed
Dec 7, 2022
| } | ||
|
|
||
| impl ReadHalf { | ||
| fn poll_read_priv(&mut self, cx: &mut Context<'_>, buf: &mut ReadBuf) -> Poll<Result<()>> { | ||
| if self.is_closed || buf.capacity() == 0 { | ||
| if buf.capacity() == 0 { |
There was a problem hiding this comment.
Why remove this check for closed?
There was a problem hiding this comment.
see #63 (comment)
| match host.tcp.socket_mut(&self.pair) { | ||
| Some(socket) => { | ||
| ready!(socket.poll_read_ready(cx)); | ||
| unsafe { |
There was a problem hiding this comment.
I wonder if it makes sense to break up the unsafe blocks to only the unsafe components instead of wrapping it all in one block. That said, I don't remember how we do it in tokio so this could be fine.
There was a problem hiding this comment.
from the snippets I see in tokio, unsafe blocks seem to often contain whole blocks rather than single statements
|
Closing due to no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
TcpStreampeekandpoll_peekmethods.depends on #63