Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC example #81

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Add gRPC example #81

merged 2 commits into from
Feb 10, 2023

Conversation

LucioFranco
Copy link
Member

This commit adds a simple gRPC example using tonic and hyper.

This commit adds a simple gRPC example using tonic and hyper.
Copy link
Contributor

@mcches mcches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real nice!

}
}

mod connector {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about a hyper feature for this in turmoil? Premature maybe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the connection trait (the main reason we have to newtype) will be in hyper 1.0 so I am not sure if that is the right approach. Maybe adding a turmoil-hyper library could work.

examples/grpc/src/main.rs Outdated Show resolved Hide resolved
examples/grpc/helloworld.proto Outdated Show resolved Hide resolved
@LucioFranco LucioFranco merged commit b212467 into main Feb 10, 2023
@LucioFranco LucioFranco deleted the lucio/grpc branch February 10, 2023 14:04
@mcches mcches mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants