Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UI to scenes rather than code generated #49

Closed
TokisanGames opened this issue Feb 3, 2023 · 1 comment
Closed

Change UI to scenes rather than code generated #49

TokisanGames opened this issue Feb 3, 2023 · 1 comment
Milestone

Comments

@TokisanGames
Copy link
Owner

It's very difficult for us to improve and build upon the UI when generated by code. It should be built as a scene in Godot and instanced by the code.

eg

const UI = "res://addons/gterrain/ui/GTerrainUI.tscn"

ui = load(UI).instantiate()
ui.ted = self
add_control_to_bottom_panel(ui, "Terrain Editor")
make_bottom_panel_item_visible(ui)
@TokisanGames TokisanGames added the enhancement New feature or request label Feb 3, 2023
@TokisanGames TokisanGames added this to the Minimum Viable Product milestone Feb 3, 2023
@outobugi
Copy link
Collaborator

outobugi commented Feb 3, 2023

I strongly disagree. I find it much easier to work on the UI when it's all in code.
The UI code could be separated to multiple scripts instead of sub classes.

@outobugi outobugi removed the enhancement New feature or request label Feb 3, 2023
Repository owner locked and limited conversation to collaborators Feb 3, 2023
@outobugi outobugi converted this issue into discussion #50 Feb 3, 2023
@TokisanGames TokisanGames modified the milestones: MVP Release, Alpha Jul 4, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants