Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: concur.threads, add join #1651

Merged
merged 2 commits into from
Jul 3, 2023
Merged

lib: concur.threads, add join #1651

merged 2 commits into from
Jul 3, 2023

Conversation

michaellilltokiwa
Copy link
Member

@michaellilltokiwa michaellilltokiwa commented Jun 26, 2023 •
edited

I implemented this mainly because of the ctrie tests.

@michaellilltokiwa michaellilltokiwa requested a review from a team June 28, 2023 13:46
fridis
fridis approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need an effect that groups thread operation like spawn and join, but this is independent of this PR:

@fridis fridis merged commit 4eba582 into tokiwa-software:main Jul 3, 2023
4 checks passed
@michaellilltokiwa michaellilltokiwa mentioned this pull request Aug 2, 2023
Closed
@michaellilltokiwa michaellilltokiwa deleted the thread_join branch October 11, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaellilltokiwa @fridis