fe: Add support for nested lazy values, fix #1665 #1672
Merged
+277
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem essentially was that in nested calls, actual arguments of inner calls were mapped before outer calls, which results in wrong outer features for the instances of Lazy created. This patch solves this by - splitting up wrapInLazyAndThenPropagateExpectedType (what was named the wrong way around) into two phases: propagateExpectedType and wrapInLazy - changing the order for wrap*InLazy to process outer calls before actuals in inner calls. As a bonus, this patch adds support for automatic wrapInLazy for assignments to fields such as i Lazy i32 := f x A regression test testing three levels of nested lazy arguments and lazy assignments to fields is also added.
maxteufel
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem essentially was that in nested calls, actual arguments of inner calls were mapped before outer calls, which results in wrong outer features for the instances of
Lazycreated.This patch solves this by
splitting up
wrapInLazyAndThenPropagateExpectedType(what was named the wrong way around) into two phases:propagateExpectedTypeandwrapInLazychanging the order for
wrapInLazyto process outer calls before actuals in inner calls.As a bonus, this patch adds support for automatic
wrapInLazyfor assignments to fields such asA regression test testing three levels of nested lazy arguments and lazy assignments to fields is also added.