Remove explicit ref types
#1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit ref version of features, where needed, are created using a parent feature of `ref` type, i.e., instead of a is ... v ref a := ... we use an explicity ref feature `ra` as follows ra ref is ... a : ra is v ra := ...
Ideally, I would like to remove `RefOrVal.Value` altogether, but this is still used too often in AIR and later phases.
maxteufel
previously approved these changes
Jul 11, 2023
maxteufel
dismissed
their stale review
I did not see that the tests were failing...
Since explicit refs in types are no longer supported, they can no longer result in errors.
Since explicit refs in types are no longer supported, they can no longer result in errors.
maxteufel
requested changes
Jul 13, 2023
maxteufel
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit
reftypes can be replaced by inheriting from areffeatures and using this instead. I do no see that creating arefexplicitly has many advantages.Not having
reftypes brings us one step closer to avoiding the double parsing foractualthat can be a type or an expression.