Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be/jvm: implement the concur.util.loadFence and concur.util.storeFence intrinsics #1922

Merged

Conversation

maxteufel
Copy link
Collaborator

No description provided.

@maxteufel maxteufel requested a review from fridis August 29, 2023 05:42
@maxteufel
Copy link
Collaborator Author

@fridis I believe monitorenter followed by monitorexit should be equivalent to synchronized (LOCK_FOR_ATOMIC) {}, but please confirm this.

Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had hoped we could map the fences to the internal fences in OpenJDK, but this does not seem to be possible any more...

So ok for this patch, we might not be able to do any better.

@maxteufel maxteufel merged commit 091957f into tokiwa-software:main Sep 18, 2023
4 checks passed
@maxteufel maxteufel deleted the be-jvm-load-store-fence-intrinsics branch September 18, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants