Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fe: fix #1943: Using type parameter as outer type #1944

Merged
merged 1 commit into from
Sep 3, 2023
Merged

fe: fix #1943: Using type parameter as outer type #1944

merged 1 commit into from
Sep 3, 2023

Conversation

fridis
Copy link
Member

@fridis fridis commented Sep 3, 2023

I was unsure when I wrote this code if using a type parameter as an outer type actually makes sense, but it does as shown in the examples of the regression test.

The bug that is patch fixes was that the constraint type of the type parameter was not resolved yet and hence not usable.

I was unsure when I wrote this code if using a type parameter as an outer type
actually makes sense, but it does as shown in the examples of the regression
test.

The bug that is patch fixes was that the constraint type of the type parameter
was not resolved yet and hence not usable.
@fridis
Copy link
Member Author

fridis commented Sep 3, 2023

Merging since I need this tomorrow. Please review anyway.

@fridis fridis merged commit c76d337 into main Sep 3, 2023
5 checks passed
Copy link
Collaborator

@maxteufel maxteufel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (Note that I apparently can't mark this as approved anymore, since it is already merged.)

@michaellilltokiwa michaellilltokiwa deleted the fix_1943 branch September 4, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants