ast: remove type inference in case of routine with explicit type and =>
#2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`=>` For a routine declaration of the form r() t => v The result type was ignored and inferred from `v`. The reason was that the Impl was set to RoutineDef, while it should be Routine in this caes. This patch makes sure that if a type is present in a routine declaration, the kind will be `Routine`, not `RoutineDef`.
…ue` as type Routines like r() ref => v f ref := v should not be considered to have a type declaration.
The error message used the show an empty result type. Extended regression test 350.
maxteufel
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a routine declaration of the form
The result type was ignored and inferred from
v. The reason was that the implementation was set toRoutineDef, while it should beRoutinein this case.This patch makes sure that if a type is present in a routine declaration, the kind will be
Routine, notRoutineDef.