Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be/jvm: introduce a null type that is compatible to all types #2089

Merged
merged 1 commit into from
Oct 19, 2023
Merged

be/jvm: introduce a null type that is compatible to all types #2089

merged 1 commit into from
Oct 19, 2023

Conversation

maxteufel
Copy link
Collaborator

No description provided.

@maxteufel maxteufel linked an issue Oct 17, 2023 that may be closed by this pull request
be/jvm: introduce null type that is compatible to all types #2082
Closed
@maxteufel
Copy link
Collaborator Author

I'm not sure if I like the asymmetry of sameAs with this change, but that can also be interpreted as a good thing (the null type is the same as any arbitrary type, but a given type that is not the null type is not the same as the null type).

@maxteufel maxteufel requested a review from fridis October 17, 2023 07:55
fridis
fridis requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a suggestion to keep sameAs symmetric.

src/dev/flang/be/jvm/classfile/ClassFileConstants.java Outdated Show resolved Hide resolved
@maxteufel maxteufel requested a review from fridis October 17, 2023 12:29
@fridis fridis merged commit b864a46 into tokiwa-software:main Oct 19, 2023
3 of 4 checks passed
@maxteufel maxteufel deleted the fix_2082 branch November 20, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

@michaellilltokiwa michaellilltokiwa michaellilltokiwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

be/jvm: introduce null type that is compatible to all types
3 participants
@maxteufel @fridis @michaellilltokiwa