air: replace Clazz.actualClazz by Clazz.handDown(), fix #2214 #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with `Clazz.actualClazz` was that it replaces all generics found in parents and in outer features. This is a problem when a feature inherits from one of its outer features since there are two possible values of the actual generics and for the examplein #2214, the wrong one was used. With this patch, `Clazzes.down` now hands down an inherted type along the inheritance change in each nesting level of features, so we have much better control how inherited types are replaced by the actual values provided in the inherts-call. This patch also adds a test case with the code from #2214 plus the flang.dev example `primes6_broken_map.fz` that showed this problem since a long time.
fridis
changed the title
michaellilltokiwa
approved these changes
Nov 17, 2023
|
|
||
|
|
||
| /** | ||
| * Helper for handDown() to hadn down an array of types along a given inheritance chain. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with
Clazz.actualClazzwas that it replaces all generics found in parents and in outer features. This is a problem when a feature inherits from one of its outer features since there are two possible values of the actual generics and for the examplein #2214, the wrong one was used.With this patch,
Clazzes.downnow hands down an inherted type along the inheritance change in each nesting level of features, so we have much better control how inherited types are replaced by the actual values provided in the inherts-call.This patch also adds a test case with the code from #2214 plus the flang.dev example
primes6_broken_map.fzthat showed this problem since a long time.