Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be/c: don't deref heap cloned result of call #2260

Merged
merged 1 commit into from
Nov 27, 2023
Merged

be/c: don't deref heap cloned result of call #2260

merged 1 commit into from
Nov 27, 2023

Conversation

michaellilltokiwa
Copy link
Member

@michaellilltokiwa michaellilltokiwa commented Nov 22, 2023 •
edited

fixes idiom82
fixes #1835

@michaellilltokiwa michaellilltokiwa marked this pull request as ready for review November 23, 2023 09:55
@michaellilltokiwa michaellilltokiwa changed the title be/c: heap_clone target, workaround for idiom82 be/c: don't deref heap cloned result of call Nov 23, 2023
fridis
fridis approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to finally understand and fix this!

@fridis fridis merged commit f075764 into tokiwa-software:main Nov 27, 2023
4 checks passed
@michaellilltokiwa michaellilltokiwa deleted the issue/1835 branch December 6, 2023 09:45
@michaellilltokiwa michaellilltokiwa mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

be/c: unhandled dynamic target in idiom82ex.fz
2 participants
@michaellilltokiwa @fridis