Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fe: fix using .this.type inside of type feature #2296

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fe: fix using .this.type inside of type feature #2296

merged 1 commit into from
Dec 8, 2023

Conversation

michaellilltokiwa
Copy link
Member

fixes #2295

fridis
fridis requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Just one change request not to silently ignore t == null if propagateExpectedType.

src/dev/flang/ast/Call.java Outdated Show resolved Hide resolved
src/dev/flang/ast/Call.java Show resolved Hide resolved
@fridis fridis merged commit 759050a into tokiwa-software:main Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using .this.type in type feature leads to feature not found
2 participants
@michaellilltokiwa @fridis