ast: Fix check if there is an ambiguous partial application #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that for a call without an explicit target, Call._target is originally null and the called feature was searched in all outer features. If found, _target is set to the corresponding `outerFeature.this` expression. THe code to check that there is no ambiguous partial application now must not restrict its search to this target, but use the null target. In case of fields, using a specific target could even result in finding more fields due to scope checking that only happens for unqualified (i.e., w/o target) calls to fields. This caused a failure in flang.dev's design/examples/aborteffect.fz.
michaellilltokiwa
approved these changes
Dec 4, 2023
michaellilltokiwa
deleted the
fix_check_for_ambiguous_partial_application
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that for a call without an explicit target, Call._target is originally null and the called feature was searched in all outer features. If found, _target is set to the corresponding
outerFeature.thisexpression.The code to check that there is no ambiguous partial application now must not restrict its search to this target, but use the null target.
In case of fields, using a specific target could even result in finding more fields due to scope checking that only happens for unqualified (i.e., w/o target) calls to fields.
This caused a failure in flang.dev's
design/examples/aborteffect.fz.