ast/tests: Delay resolution of features with args whose types are inferred #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erred This fixes #2290 by first resolving everything else before we are resolving a feature whose argument types are inferred from actual arguments. Since type inference can results in some awful circles here, I had to add a check for such circles to avoid type inference in case of such a circle. For now, a circle is just ignored expecting this to occur only in case of recursion. Consequently, only types provided when entering this recursion will be considered for type inference for arguments. This patch adds a number of tricky type inference tests that model the example from #2290 and indirect recursion. Also, test scenarios were added where inference is used without any actual calls and the type ends up being `void`, which is wrong. This should be revisited within #2308.
The check in Impl() was left over from my debugging, while the check in Resolution.requiresCall() is wrong for recursive calls to this method, the condition is already checked in Resolution.scheduleForDeclarations().
michaellilltokiwa
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2290 by first resolving everything else before we are resolving a feature whose argument types are inferred from actual arguments.
Since type inference can results in some awful circles here, I had to add a check for such circles to avoid type inference in case of such a circle. For now, a circle is just ignored expecting this to occur only in case of recursion. Consequently, only types provided when entering this recursion will be considered for type inference for arguments.
This patch adds a number of tricky type inference tests that model the example from #2290 and indirect recursion.
Also, test scenarios were added where inference is used without any actual calls and the type ends up being
void, which is wrong. This should be revisited within #2308.I also added code to the parser to add a
SourcePositionto eachImplwhich helps during debugging.