Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: cleanup effect.fz #2352

Merged
merged 1 commit into from
Dec 18, 2023
Merged

lib: cleanup effect.fz #2352

merged 1 commit into from
Dec 18, 2023

Conversation

michaellilltokiwa
Copy link
Member

removed unused return and use0
also removed effect_mode.abort which seems useless?

@michaellilltokiwa
lib: cleanup effect.fz
ed81a9f 
removed unused `return` and `use0`
also removed `effect_mode.abort` which seems useless?
fridis
fridis approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that return is the common term used in literature for what we call abort. So maybe we should rename abort as return in a next step.

@fridis fridis merged commit 72aad81 into tokiwa-software:main Dec 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaellilltokiwa @fridis