me: Replace runtime clazzes by clazz-local map of actual clazzes, fix #2408 #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2408 The use of unique ids for all AST elements that need runtime clazz information plus arrays large enough to hold all these ideas in every clazz instance results in memory demand quadratic to the code size resulting in the high memory demand for arrays used in ryu.fz and reported in #2408. This patch replaces these large arrays by per-clazz TreeMaps that contain only those actual clazzes that are actually needed for that clazz. This also adds some NYI-comments related to #2411 and #2412. This removes caching of Callable created in the interpreter, so this might have a negative impact on interpreter performance. We might to re-introduce a caching mechanism if this turns out to be very costly.
maxteufel
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of unique ids for all AST elements that need runtime clazz information plus arrays large enough to hold all these ideas in every clazz instance results in memory demand quadratic to the code size resulting in the high memory demand for arrays used in ryu.fz and reported in #2408.
This patch replaces these large arrays by per-clazz TreeMaps that contain only those actual clazzes that are actually needed for that clazz.
This also adds some NYI-comments related to #2411 and #2412.
This removes caching of Callable created in the interpreter, so this might have a negative impact on interpreter performance. We might to re-introduce a caching mechanism if this turns out to be very costly.