lib: implement Set.add
#2533
Merged
lib: implement Set.add
#2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Set.add` being `abstract` resulted in errors for heirs of `Set` that to not have `add` when running the idioms. Eventually, `Set.add` should be removed and we should have a proper integration of mutable Sets with the `mutate` effect or some lock-free-concurrency effect.
michaellilltokiwa
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set.addbeingabstractresulted in errors for heirs ofSetthat to not haveaddwhen running the idioms.Eventually,
Set.addshould be removed and we should have a proper integration of mutable Sets with themutateeffect or some lock-free-concurrency effect.Also removed
Set.removesince this seems unused but could cause similar problem.s