lib: major restructuring of has_interval #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridis
force-pushed
the
lib_remove_has_interval_max
branch
from
66dafa3
to
2ccb084
Compare
Added new feature `interval` that is the result of `infix ..`. Renamed lower/upper as from/through for clarity. Clarified behaviour for `step` equal to zero, which is now forbidden, or negative `step` with `from >= through`. Fixed overflow for large intervals like `(i8 -128 .. 127 : 4).contains 4`. Added `option.val`, `option.or_else`, `num_option.or_else` and `num_option.as_list` since they turned out useful even though I ended up not using all of them in this patch.
fridis
force-pushed
the
lib_remove_has_interval_max
branch
from
2ccb084
to
464571b
Compare
maxteufel
reviewed
Feb 15, 2024
maxteufel
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new feature
intervalthat is the result ofinfix ...Renamed lower/upper as from/through for clarity.
Clarified behaviour for
stepequal to zero, which is now forbidden, or negativestepwithfrom >= through.Fixed overflow for large intervals like
(i8 -128 .. 127 : 4).contains 4.Added
option.val,option.or_else,num_option.or_elseandnum_option.as_listsince they turned out useful even though I ended up not using all of them in this patch.