-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
be/c: use temporary file for emitting c-code #2605
be/c: use temporary file for emitting c-code #2605
Conversation
PR due to @maxteufel suggestion from here: tokiwa-software#2574 (review)
It is much nicer not dumping temporary files into the current directory. I think these temp files are not deleted automatically, so this will result in lots of temp files with ending up in /tmp. But when they are automatically deleted, we will need some option for the Also, I think it would be better to include the main feature name just to make this a little less confusion, i..e, create |
My understanding is that the OS is responsible to delete these files after a while. For example when rebooting. |
The OS can delete them after a while, but likely we will do ourselves a favor if we remove the files unless an option is set to keep the files. You don't want to try every one of them if you're debugging something. |
@maxteufel I added an option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected this to simply keep the files in /tmp but this works too.
@@ -145,8 +145,6 @@ int fzE_munmap(void * mapped_address, const int file_size); | |||
* results is unequality of +0 and -0 and equality of NaN unless undefined bits | |||
* differ, etc. | |||
* | |||
* NYI: CLEANUP #2122: Move impleementation to fz.c / fzlib.o or similar! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that done without precompiling the library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently yes, see issue #2589
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no i mean this comment shouldn't be removed then since the task is not done yet.
tests/check_simple_example_c.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not forget to change this in flang.dev, too
PR due to @maxteufel suggestion from here: #2574 (review)
example output: