lib/tests: Relax precondition for step when creating interval
#2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an interval `a..a:s`, it is now allowed that step is any value including `s=0`, which gives the interval with singe element `a`. This fixes `content/examples/examples/fib_iterative_neg.fz` from fuzion-lang.dev, which gives an example for why this relaxation makes sense. This also required changes in `size` and `contains`. This patch also improves `interval.as_string` for infinite intervals and adds `postifx ..∞` as an alias for `postifx ..`. Also added a test to check various combinations of values for `from`, `through` and `step`.
maxteufel
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an interval
a..a:s, it is now allowed that step is any value includings=0, which gives the interval with singe elementa.This fixes
content/examples/examples/fib_iterative_neg.fzfrom fuzion-lang.dev, which gives an example for why this relaxation makes sense.This also required changes in
sizeandcontains.This patch also improves
interval.as_stringfor infinite intervals and addspostifx ..∞as an alias forpostifx ...Also added a test to check various combinations of values for
from,throughandstep.