be/interpreter: fix ClassCastException #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridis
requested changes
Mar 14, 2024
Problem was that the test socket did not use interpreter for starting server. Now it does but had to fix two intrinsics.
michaellilltokiwa
force-pushed
the
fix_interpreter_socket_server
branch
from
8a554f1
to
0fa58f6
Compare
fridis
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that the test socket did not use interpreter for starting server. Now it does but had to fix two intrinsics.
Also some unrelated cleanups/improvements that I did not want to add yet another PR for.