macOS: try fix finding libjvm.dylib #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridis
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Good if this fixed the macOS builds.
Can you add some context into the commit message or as a comment to the code, in particular:
- what error are you trying to fix (I guess the failing MacOS builds, but some detail would be good)
- why do you think that this solves the problem and where did you get this information from
Thanks.
[ci skip]
michaellilltokiwa
force-pushed
the
macos_dylib_fix
branch
from
0177515
to
9273e64
Compare
|
@fridis yeah, I should have added this information... |
fridis
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not test this.
[ci skip]