Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add test for #2325 #2748

Merged
merged 1 commit into from
Mar 25, 2024
Merged

tests: add test for #2325 #2748

merged 1 commit into from
Mar 25, 2024

Conversation

michaellilltokiwa
Copy link
Member

fixes #2325

maxteufel
maxteufel reviewed Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@maxteufel maxteufel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely happy with adding a test that then fails because of an integer overflow, presumably.

fridis
fridis reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not check that this test actually fails, so this PR should not be merged as long as if the tail recursion optimization does not work yet.

@fridis
Copy link
Member

fridis commented Mar 25, 2024

I'm not entirely happy with adding a test that then fails because of an integer overflow, presumably.

I am not worried about this, but might be good to have a comment in the test that a precondition failure is the desired result.

@maxteufel maxteufel merged commit dee22ed into tokiwa-software:main Mar 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

@maxteufel maxteufel maxteufel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AoC Issue: list.fold needs tail recursion optimization in JVM backend
3 participants
@michaellilltokiwa @fridis @maxteufel