be: replace interpreter by interpreter2 #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridis
requested changes
Mar 21, 2024
There was a problem hiding this comment.
This is a big step ahead!
May comments are mostly about code structure and comments that in parts is IMHO worse than in the old interpreter, but probably easy to fix.
Also, please add an issue to add support for stack traces of a quality similar to the old interpreter. This is a feature I will miss.
fridis
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Looks good!
Please keep an eye on the jenkins flang.dev results and fix any new issues that will arise (like missing stack traces in err output etc.). Keep an eye on the change of total time spent in the interpreter, might make sense to use -XjavaProf to understand what is the most performance critical part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.