ast: replace NYI by explanatory comment #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw. I'm not sure the explained reason is the only reason why outerrefs are needed for abstract features. |
maxteufel
requested changes
Mar 25, 2024
I think it probably is. When I added the NYI-comment, I could not think of any reason at all. Outer refs can only be used by code in a routine or its precondition, or by code in any child. There is no way to inherit from an abstract and there is no code in an abstract, so the precondition is what remains. |
Co-authored-by: Max Teufel <max@teufelsnetz.com>
maxteufel
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]