fe/me: always use .fum file as input for middle end #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since errors can not be written to fum file, I needed to add a `Errors.showAndExit()` after `new FrontEnd()`
fridis
reviewed
Mar 28, 2024
There was a problem hiding this comment.
This looks very promising. The hard part is to get rid of the awful dependency from Clazz to SrcModule.
In the current version of your solution, you instead introduce a dependency from Clazz to Module. I first thought this would introduce a cyclic dependency, but it does not. Nevertheless, it might be better to have a dedicated class fe.FeatureLookup or similar that contains only the essential methods needed in air to make it easier to change this if needed. Maybe FeatureLookup could be just an interface that is implemented by Module.
fridis
approved these changes
Mar 28, 2024
Co-authored-by: Fridtjof Siebert <48821596+fridis@users.noreply.github.com>
Co-authored-by: Fridtjof Siebert <48821596+fridis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since errors can not be written to fum file, I needed to add a
Errors.showAndExit()afternew FrontEnd()