Package update #17

mittalaa · 2022-08-01T05:34:11Z

Last Sync-Up occurred on Sep 4, 2019. This PR is for syncing up with latest(Aug 1, 2022).
Changes

Pulled Latest Commit from graphql-go master. (Support for extensions was update)

In this PR we readded the custom change lost due to update like int64 support.

Note: We are trying to merge this PR into master since we are planning to use the latest features offered by graphql-go.
New Features and bug fixes introduces since last syncup: https://github.com/graph-gophers/graphql-go/releases

Support for embedded struct type in resolver

Adding example and documentation for how to create custom error implementations which include `extensions` within their `error` payload

…tom-errors Add Example of Custom Errors

Print context to panic log

Producing clearer error messages when field input arguments are implemented by code: * Which does not match the schema e.g. missing field; or * Function missing struct wrapper for field arguments

…input-resolver-mismatch-with-schema Clarify errors for mismatching input implementation

…ntrypoints-without-explicit-schema Allow `schema` to be omitted when using default root op names

Fix graph-gophers#357 - Allow passing integers as arguments to graphql.Time parameters

Multi-line descriptions need to have their common indentation level (which results from indentation of that part of the schema, rather than being intentional for the description text) removed to ensure the descriptions use the correct value, are formatted correctly etc This is to meet the condition documented in the GraphQL spec: https://graphql.github.io/graphql-spec/June2018/#sec-String-Value > Since block strings represent freeform text often used in indented > positions, the string value semantics of a block string excludes > uniform indentation and blank initial and trailing lines via > BlockStringValue().

…tation-from-blockstring-descriptions Strip Common Indentation from BlockString Descriptions

Syntax highlighting fixed in README

Fixed small punctuation and added my walkthrough package

Adding walkthrough

Added changes lost after package update

Readded Export query name method functionality after package update

…nsion details

kumaramritansh · 2022-11-28T09:48:00Z

errors/errors.go

+	Path          []interface{}          `json:"path,omitempty"`
+	Rule          string                 `json:"-"`
+	ResolverError error                  `json:"-"`
+	Extensions    map[string]interface{} `json:"extensions"`


Updated Extensions type from a struct to a map

kumaramritansh · 2022-11-28T09:55:42Z

errors/errors.go

-		Message: fmt.Sprintf(format, a...),
+		Err:        err,
+		Message:    fmt.Sprintf(format, a...),
+		Extensions: make(map[string]interface{}),


Initialising Extension fields while returning a QueryError to avoid assignment to entry in nil map error

kumaramritansh · 2022-11-28T09:56:36Z

errors/errors.go

}
+

updated code syntax as Extensions is update from a struct type to a map type field.

kumaramritansh · 2022-11-28T09:57:53Z

errors/errors.go

 	for _, loc := range err.Locations {
 		str += fmt.Sprintf(" (line %d, column %d)", loc.Line, loc.Column)
 	}
 	return str
 }

+func (err *QueryError) Unwrap() error {


Unwarp() returns any underlying error if available.

kumaramritansh · 2022-11-28T10:11:16Z

graphql.go

+		maxParallelism: 10,
+		tracer:         noop.Tracer{},
+		logger:         &log.DefaultLogger{},
+		panicHandler:   &errors.DefaultPanicHandler{},


initialising panicHandler to create custom panic errors that occur during query execution

kumaramritansh · 2022-11-28T10:20:36Z

graphql.go

+		maxParallelism: 10,
+		tracer:         noop.Tracer{},
+		logger:         &log.DefaultLogger{},
+		panicHandler:   &errors.DefaultPanicHandler{},
 	}
 	for _, opt := range opts {
 		opt(s)
 	}



Add context to validation tracing

1a55b96

24abfa5

kumaramritansh · 2022-11-28T10:22:21Z

graphql.go

+	panicHandler             errors.PanicHandler
+	useStringDescriptions    bool
+	disableIntrospection     bool
+	subscribeResolverTimeout time.Duration


Added possibility to customize subscription resolver timeout value
d77614a

kumaramritansh · 2022-11-28T10:29:48Z

graphql.go

-		return &Response{Errors: []*errors.QueryError{&errors.QueryError{Message: "graphql-ws protocol header is missing"}}}
+		return &Response{Errors: []*errors.QueryError{{Message: "graphql-ws protocol header is missing"}}}
+	}
+	if op.Type == query.Mutation {


Allow schema to be omitted when using default root op names 6c0f0e3

kumaramritansh · 2022-11-28T10:47:56Z

time.go

+		var err error
+		t.Time, err = time.Parse(time.RFC3339, string(input))
+		return err
+	case int32:
 		t.Time = time.Unix(int64(input), 0)
 		return nil


graphql.Time unmarshal unix nano time

kumaramritansh · 2022-11-28T10:49:25Z

time.go

@@ -31,14 +31,27 @@ func (t *Time) UnmarshalGraphQL(input interface{}) error {
 		var err error
 		t.Time, err = time.Parse(time.RFC3339, input)
 		return err
-	case int:
+	case []byte:


expose packer.Unmarshaler interface as graphql.Unmarshaler 04aa634

kumaramritansh · 2022-11-28T10:51:55Z

types/argument.go

@@ -0,0 +1,44 @@
+package types


add types package bf0a0cc

kumaramritansh · 2022-11-29T07:02:47Z

SECURITY.md

+| ------- | ------------------ |
+| 1.x     | :white_check_mark: |
+| < 1.0   | :x:                |
+


The changes were synced to this commit graph-gophers@64f8084 committed on Jul 20 2022 and the latest stable version is v1.4.0 which was released on April 11 2022 so this syncup with graphq-gophers/graphql-go is free of MaxDepth security vulnerability as this vulnerability is detected in versions <v1.3.0

GHSA-mh3m-8c74-74xh

kumaramritansh · 2022-11-29T09:29:22Z

scripts/golangci_install.sh

@@ -0,0 +1,407 @@
+#!/bin/sh


semaphore CI script

kumaramritansh · 2022-11-29T09:30:17Z

nullable_types.go

@@ -0,0 +1,166 @@
+package graphql


Added Support for nullable types fced4f6

kumaramritansh · 2022-11-29T09:32:56Z

subscriptions.go

+		Limiter:                  make(chan struct{}, s.maxParallelism),
+		Tracer:                   s.tracer,
+		Logger:                   s.logger,
+		PanicHandler:             s.panicHandler,


Added option for custom panichandler

kumaramritansh · 2022-11-29T09:33:32Z

subscriptions.go

+		Tracer:                   s.tracer,
+		Logger:                   s.logger,
+		PanicHandler:             s.panicHandler,
+		SubscribeResolverTimeout: s.subscribeResolverTimeout,


Added possibility to customise subscription resolver timeout value

kumaramritansh · 2022-11-29T09:40:26Z

trace/noop/trace.go

@@ -0,0 +1,24 @@
+// Package noop defines a no-op tracer implementation.


Refactor Trace Package 24abfa5

kumaramritansh · 2022-11-29T11:14:37Z

example/apollo_federation/README.md

@@ -0,0 +1,35 @@
+# Apollo Federation


Apollo Federation Spec: Fetch service capabilities
https://github.com/graph-gophers/graphql-go/pull/507/files

With these changes, we can use graphql-go as subgraph behind Apollo Federation Gateway even though it's still not fully implements the specification, but at least it's one step closer

kumaramritansh · 2022-11-29T13:04:51Z

example/social/social.go

@@ -27,9 +27,13 @@ const Schema = `
 		role: Role!
 	}



Use struct fields as resolvers instead of methods example

eloyekunle and others added 30 commits June 25, 2019 14:19

Support for embedded struct type in resolver

f40cd36

fix bug in slice pop

d5b02b1

fix bug while finding field

6110b37

add 'getFieldCount' to resolve ambiguity

8f68317

Increase extensions test coverage

f39c0f0

Remove duplicate unit tests

641ae19

rename 'getFieldCount' to 'fieldCount'

c94cde5

add test for ambiguous field panic

be8816b

add unit tests for embedded struct feature

3f7a8e9

rename TestEmbedded => TestEmbeddedStruct

943d21c

Merge pull request graph-gophers#338 from eloyekunle/master

38a077b

Support for embedded struct type in resolver

Fixes graph-gophers#357

5fe34fd

Actually fix graph-gophers#357

4edb8fa

Print context to panic log

01c95b0

Add Example of Custom Errors

0fb5fc2

Adding example and documentation for how to create custom error implementations which include `extensions` within their `error` payload

Merge pull request graph-gophers#361 from dackroyd/add-example-of-cus…

9068de6

…tom-errors Add Example of Custom Errors

Merge pull request graph-gophers#360 from kumparan/old_ver

0a9cfbe

Print context to panic log

Clarify errors for mismatching input implementation

81e957c

Producing clearer error messages when field input arguments are implemented by code: * Which does not match the schema e.g. missing field; or * Function missing struct wrapper for field arguments

Allow schema to be omitted when using default root op names

6c0f0e3

Merge pull request graph-gophers#363 from dackroyd/clearer-error-for-…

72f6639

…input-resolver-mismatch-with-schema Clarify errors for mismatching input implementation

Merge pull request graph-gophers#364 from dackroyd/populate-default-e…

a5bf804

…ntrypoints-without-explicit-schema Allow `schema` to be omitted when using default root op names

Merge pull request graph-gophers#358 from MaxInertia/master

4450565

Fix graph-gophers#357 - Allow passing integers as arguments to graphql.Time parameters

Merge pull request graph-gophers#356 from dackroyd/strip-common-inden…

adde0d0

…tation-from-blockstring-descriptions Strip Common Indentation from BlockString Descriptions

Syntax highlighting fixed in README

5098fd4

Merge pull request graph-gophers#366 from pavemaksim/patch-1

5ef3e23

Syntax highlighting fixed in README

Add walkthrough

9508a02

Fixed small punctuation and added my walkthrough package

Update README.md

98f2350

Merge pull request graph-gophers#367 from ZAYDEK/master

f33e813

Adding walkthrough

Add support for directives in schema parser

a579090

kumaramritansh and others added 10 commits August 1, 2022 14:47

Added changes lost after package update

86f5bb0

Merge pull request #18 from tokopedia/previous_changes

06a882d

Added changes lost after package update

merging old prs

e1e0243

adding gqlerrors support

e788b87

adding dev message, error code support

9c90c13

Readded Export query name method functionality after package update

e92a45a

Merge pull request #21 from tokopedia/package-update-export-query-name

64f230f

Readded Export query name method functionality after package update

resolving conflicts, removed codeql-analysis.yml

12026c7

Fix: extension initialisation and updated error method to return exte…

c7c9ca6

…nsion details

updated QueryError Extensions to not emit if empty

2b4db5a

kumaramritansh reviewed Nov 28, 2022

View reviewed changes

errors/errors.go

}

Copy link

kumaramritansh Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated code syntax as Extensions is update from a struct type to a map type field.

kumaramritansh reviewed Nov 28, 2022

View reviewed changes

types/argument.go

@@ -0,0 +1,44 @@

package types

Copy link

kumaramritansh Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add types package bf0a0cc

kumaramritansh reviewed Nov 29, 2022

View reviewed changes

scripts/golangci_install.sh

@@ -0,0 +1,407 @@

#!/bin/sh

Copy link

kumaramritansh Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semaphore CI script

kumaramritansh reviewed Nov 29, 2022

View reviewed changes

nullable_types.go

@@ -0,0 +1,166 @@

package graphql

Copy link

kumaramritansh Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Support for nullable types fced4f6

kumaramritansh reviewed Nov 29, 2022

View reviewed changes

trace/noop/trace.go

@@ -0,0 +1,24 @@

// Package noop defines a no-op tracer implementation.

Copy link

kumaramritansh Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor Trace Package 24abfa5

kumaramritansh reviewed Nov 29, 2022

View reviewed changes

example/social/social.go

@@ -27,9 +27,13 @@ const Schema = `

role: Role!

}

Copy link

kumaramritansh Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use struct fields as resolvers instead of methods example

Umanish merged commit 6fb9e53 into master May 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Package update #17

Package update #17

mittalaa commented Aug 1, 2022 •

edited by kumaramritansh

kumaramritansh Nov 28, 2022

kumaramritansh Nov 28, 2022

kumaramritansh Nov 28, 2022

kumaramritansh Nov 28, 2022

kumaramritansh Nov 28, 2022

kumaramritansh Nov 28, 2022 •

edited

kumaramritansh Nov 28, 2022

kumaramritansh Nov 28, 2022

kumaramritansh Nov 28, 2022

kumaramritansh Nov 28, 2022

kumaramritansh Nov 28, 2022

kumaramritansh Nov 29, 2022

kumaramritansh Nov 29, 2022

kumaramritansh Nov 29, 2022

kumaramritansh Nov 29, 2022

kumaramritansh Nov 29, 2022

kumaramritansh Nov 29, 2022

kumaramritansh Nov 29, 2022 •

edited

kumaramritansh Nov 29, 2022

		@@ -0,0 +1,24 @@
		// Package noop defines a no-op tracer implementation.

Package update #17

Package update #17

Conversation

mittalaa commented Aug 1, 2022 • edited by kumaramritansh

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumaramritansh Nov 28, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumaramritansh Nov 29, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mittalaa commented Aug 1, 2022 •

edited by kumaramritansh

kumaramritansh Nov 28, 2022 •

edited

kumaramritansh Nov 29, 2022 •

edited