Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Branch Old Story #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New Branch Old Story #32

wants to merge 1 commit into from

Conversation

yashika51
Copy link
Member

It's too late in the US and Canada. Isn't it?

<div class="Desk">
<p className="lt-card lt-hover text-align:left">
<ul>
{office.Users.map((user) => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is creating a list of all the users and a link to join their session. We want to use the interface that you created with Nick's sketches! That means instead of a li you'd have a similar structure to your first commit in #29

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want an interface which shows the original name and pull up button should have the link to join their session right?
But how do we access the user names, like if I want 1st users name to get displayed how do I do smth similar to user.name[0].

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

office.Users is an array of all the users. When we call .map on it, we are transforming each user into a React element so that we can render it. As such, all of the fields in the office.Users in Firebase are available here, such as user.name, and you can consider how to create a React element for a single user inside the map function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood!
Another question, we have to do smth similar for dashboard as well?
I couldn't see how it looks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be safe leaving the dashboard as it is for now since you cannot see it anyways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@akainth015
Copy link
Member

It's 2:03 in the morning here right now 🤣

@yashika51
Copy link
Member Author

It's 2:03 in the morning here right now 🤣

Welcome to the club 🎉. You are on the way to become nocturnal 😂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants