fallback to toString() when toStringC14N(1) gives an empty string #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tokuhirom would be very kind of you if you could commit this PR and publish a new version on CPAN. Thank you! |
|
@tokuhirom thank you for merging. It would be nice to have this version now published on CPAN. Thank you in advance! |
|
i will do it asap |
tokuhirom
added a commit
that referenced
this pull request
Jan 9, 2024
Changelog diff is:
diff --git Changes Changes
index 050dadd..ffa5d96 100644
--- Changes
+++ Changes
@@ -2,6 +2,13 @@ Revision history for Perl extension HTML::TreeBuilder::LibXML
{{$NEXT}}
+0.27 2024-01-09T06:19:12Z
+
+ - don't have the parser string blanks by default #15
+ #15
+ - fallback to toString() when toStringC14N(1) gives an empty string #17
+ #17
+
0.26 2016-10-19T15:03:00Z
- Improve `HTML::TreeBuilder::LibXML::Node->new` compatibility
|
Released 0.27! I apologize for my laziness.
--
tokuhirom
2024年1月6日(土) 16:45 Dietrich Streifert ***@***.***>:
… @tokuhirom <https://github.com/tokuhirom> thank you for merging. It would
be nice to have this version now published on CPAN. Thank you in advance!
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFEXHPAZCBIB676SFD3FDYND6K5AVCNFSM46V4YG6KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBXHE2TQNJTGI2Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With libxml2 2.9.12, toStringC14N(1) gives an empty string when parsing an empty tree. In these cases, it makes more sense to fallback to toString().
Fixes #16