Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is a conventaion that the remote should be named origin #287

Merged
merged 1 commit into from
Mar 22, 2020
Merged

It is a conventaion that the remote should be named origin #287

merged 1 commit into from
Mar 22, 2020

Conversation

thibaultduponchelle
Copy link
Contributor

@thibaultduponchelle thibaultduponchelle commented Mar 22, 2020

Hello,

First thank you a lot for this great tool !!! ❤️

Some features won't work if your remote is not named origin.
If you have only one remote but it is named "central", minil test won't be able to generate badges for instance.

This pull request is the very minimum (document the convention).

I tried to do more than that (adding a check) but it's not clear what would be the best approach :

  • If I add a check in sub CheckOrigin (currently only check that a remote is set, not the name of it), it seems it will be only be executed during Release action.
  • If I add a check in check_git it will be executed for every actions even if some of them do not require to access the remote url.
  • We can add another sub check_git_origin and add it as a step of some actions (which ones?)
  • If there is only one remote and it is not named origin, maybe we can use it instead (require more changes)

In short, I don't know and I would be glad to hear your opinion.
(my current personal favorite approach is the check_git)

The pull request at least document the convention which is already a very helpful and make it clear for every user.

Best regards.

Thibault

@skaji skaji merged commit ebedbf8 into tokuhirom:master Mar 22, 2020
@skaji
Copy link
Collaborator

skaji commented Mar 22, 2020

thanks 😃

skaji added a commit that referenced this pull request Mar 30, 2020
Changelog diff is:

diff --git a/Changes b/Changes
index 823d68f..161c920 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,11 @@ Revision history for Perl extension Minilla
 
 {{$NEXT}}
 
+v3.1.10 2020-03-30T10:53:54Z
+    - Add gitlab badges (thibaultduponchelle, srchulo #288, #285)
+    - It is a conventaion that the remote should be named origin (thibaultduponchelle #287)
+    - Update travis.yml template; now travis xenial environment supports perl 5.14+ (#289)
+
 v3.1.9 2020-01-24T13:59:54Z
     - Use '--cleanup=verbatim' option with commit not to erase empty line in diff output (kaz-utashiro #281)
     - Fix grammar (anirvan #286)
syohex added a commit that referenced this pull request Sep 12, 2020
Changelog diff is:

diff --git a/Changes b/Changes
index 161c920..b0fb93d 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,10 @@ Revision history for Perl extension Minilla
 
 {{$NEXT}}
 
+v3.1.11 2020-09-12T11:05:53Z
+    - Improve 'minil release' error message(#264)
+    - Improve document(#294)
+
 v3.1.10 2020-03-30T10:53:54Z
     - Add gitlab badges (thibaultduponchelle, srchulo #288, #285)
     - It is a conventaion that the remote should be named origin (thibaultduponchelle #287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants