Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test::TCP installation issue #60

Closed
msgnaf opened this issue May 11, 2017 · 0 comments · Fixed by #61
Closed

Test::TCP installation issue #60

msgnaf opened this issue May 11, 2017 · 0 comments · Fixed by #61

Comments

@msgnaf
Copy link

msgnaf commented May 11, 2017 •
edited

Information about a bug in the perl module Test::TCP. My system is Windows 7 Professional, Service Pack 1. I am using Strawberry Perl version 5.24.1 built for MSWin32-x64-multi-thread. The output when running cpan Test::TCP in a command window with administrator privileges is attached:

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. Alle Rechte vorbehalten.

C:\windows\system32>cpan Test::TCP
Loading internal null logger. Install Log::Log4perl for logging messages
CPAN: CPAN::SQLite loaded ok (v0.211)
Database was generated on Wed, 10 May 2017 08:52:13 GMT

Running install for module 'Test::TCP'
CPAN: Digest::SHA loaded ok (v5.96)
CPAN: Compress::Zlib loaded ok (v2.07)
Checksum for C:\STRAWB~1\cpan\sources\authors\id\T\TO\TOKUHIROM\Test-TCP-2.18.ta
r.gz ok
CPAN: Archive::Tar loaded ok (v2.24)
CPAN: YAML::XS loaded ok (v0.63)
CPAN: CPAN::Meta::Requirements loaded ok (v2.140)
CPAN: Parse::CPAN::Meta loaded ok (v2.150010)
CPAN: CPAN::Meta loaded ok (v2.150010)
CPAN: Module::CoreList loaded ok (v5.20170114_24)
Configuring T/TO/TOKUHIROM/Test-TCP-2.18.tar.gz with Makefile.PL
Checking if your kit is complete...
Looks good
Generating a dmake-style Makefile
Writing Makefile for Test::TCP
Writing MYMETA.yml and MYMETA.json
TOKUHIROM/Test-TCP-2.18.tar.gz
C:\Strawberry\perl\bin\perl.exe Makefile.PL -- OK
Running make for T/TO/TOKUHIROM/Test-TCP-2.18.tar.gz
cp lib/Test/TCP/CheckPort.pm blib\lib\Test\TCP\CheckPort.pm
cp lib/Net/EmptyPort.pm blib\lib\Net\EmptyPort.pm
cp lib/Test/TCP.pm blib\lib\Test\TCP.pm
TOKUHIROM/Test-TCP-2.18.tar.gz
C:\STRAWB~1\c\bin\dmake.exe -- OK
Running make test
"C:\Strawberry\perl\bin\perl.exe" "-MExtUtils::Command::MM" "-MTest::Harness" "-
e" "undef *Test::Harness::Switches; test_harness(0, 'blib\lib', 'blib\arch')" t/
*.t
t/00_compile.t ................. No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/00_compile.t ................. 1/1 # Test::More: 1.302075
t/00_compile.t ................. ok
t/01_simple.t .................. No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/01_simple.t .................. ok
t/02_abrt.t .................... No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/02_abrt.t .................... skipped: win32 doesn't support embedded functio
n named dump()
t/03_return_when_sigterm.t ..... No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/03_return_when_sigterm.t ..... ok
t/04_die.t ..................... No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/04_die.t ..................... ok
t/05_sigint.t .................. No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/05_sigint.t .................. skipped: this test requires SIGUSR1
t/06_nest.t .................... No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/06_nest.t .................... ok
t/07_optional.t ................ 1/2 No such signal: SIGSYS at C:/Strawberry/per
l/lib/Test2/API/Instance.pm line 312.
t/07_optional.t ................ ok
t/08_exit.t .................... No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/08_exit.t .................... ok
t/09_fork.t .................... No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/09_fork.t .................... ok
t/10_oo.t ...................... No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/10_oo.t ...................... ok
t/11_net_empty_port.t .......... 2/?     # found an empty IPv6 port
t/11_net_empty_port.t .......... 11/? Use of uninitialized value $port in concat
enation (.) or string at C:\STRAWB~1\cpan\build\Test-TCP-2.18-21\blib\lib/Net/Em
ptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.
Use of uninitialized value $port in concatenation (.) or string at C:\STRAWB~1\c
pan\build\Test-TCP-2.18-21\blib\lib/Net/EmptyPort.pm line 134.

t/11_net_empty_port.t .......... 12/? #   Failed test 'No args to wait_port is f
atal'
#   at t/11_net_empty_port.t line 79.
#                   ''
#     doesn't match '(?^:Expected .PeerService.)'
t/11_net_empty_port.t .......... 15/? # Looks like you failed 1 test of 15.
t/11_net_empty_port.t .......... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/15 subtests
t/12_pass_wait_port_options.t .. No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/12_pass_wait_port_options.t .. ok
t/13_undef_port.t .............. No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/13_undef_port.t .............. ok
t/14_listen.t .................. No such signal: SIGSYS at C:/Strawberry/perl/li
b/Test2/API/Instance.pm line 312.
t/14_listen.t .................. ok

Test Summary Report
-------------------
t/11_net_empty_port.t        (Wstat: 256 Tests: 15 Failed: 1)
Failed test:  12
Non-zero exit status: 1
Files=15, Tests=144, 116 wallclock secs ( 0.09 usr +  0.01 sys =  0.11 CPU)
Result: FAIL
Failed 1/15 test programs. 1/144 subtests failed.
dmake.exe:  Error code 255, while making 'test_dynamic'
TOKUHIROM/Test-TCP-2.18.tar.gz
C:\STRAWB~1\c\bin\dmake.exe test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try:
reports TOKUHIROM/Test-TCP-2.18.tar.gz
Stopping: 'install' failed for 'Test::TCP'.

C:\windows\system32>
mattn added a commit that referenced this issue May 11, 2017
@mattn
don't run command when the port is empty
aac1b06 
Test::TCP do hack on Windows for checking port used.

0f4510d8

But this way always return 0 with succeeded with empty port. This is not
expected behavior. So this change fix to call check_port if the port is
not defined.

fixes #60
@mattn mattn mentioned this issue May 11, 2017
Merged
tokuhirom added a commit that referenced this issue May 11, 2017
@tokuhirom
Checking in changes prior to tagging of version 2.19.
9b1a7e6 
Changelog diff is:

diff --git Changes Changes
index b690972..942a8f8 100644
--- Changes
+++ Changes
@@ -2,6 +2,24 @@ Revision history for Perl module Test::TCP

 {{$NEXT}}

+2.19 2017-05-11T13:02:47Z
+
+    commit aac1b06
+    Author: Yasuhiro Matsumoto <mattn.jp@gmail.com>
+    Date:   Thu May 11 18:40:13 2017 +0900
+
+        don't run command when the port is empty
+
+        Test::TCP do hack on Windows for checking port used.
+
+        0f4510d8
+
+        But this way always return 0 with succeeded with empty port. This is not
+        expected behavior. So this change fix to call check_port if the port is
+        not defined.
+
+        fixes #60
+
 2.18 2017-04-24T06:00:25Z
     - let the kernel select an empty port #59
       #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't run command when the port is empty tokuhirom/Test-TCP
1 participant
@msgnaf