test (and fix) that we restore the selected FH #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SelectSaver was getting confused by the localization of STDOUT, and was selecting the tmpfile on destruction. Just moving it outside of the block with the 'local's is enough to make the thing work.
miyagawa
added a commit
that referenced
this pull request
Jul 21, 2015
test (and fix) that we restore the selected FH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectSaverwas getting confused by the localization ofSTDOUT, and was selecting the tmpfile on destruction. Just moving it outside of the block with thelocals is enough to make the thing work.