Use tied file handle for STDIN #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some PSGI server don't provide a file handle for input and errors. They need to be tied to a file handle to be properly used.
|
Can you write test for this, or how to reproduce the bug you're trying to fix? |
|
In uwsgi the stream on psgi.input (and also on psgi.error, but that is no real problem) is no file handle, but a simple class with a read method, so it can't be assigned directly to *STDIN. |
|
Write that test. |
|
You can add a test and push to the branch, no need to close and reopen a new pull request. Thanks! |
added 2 commits
August 8, 2013 22:38
Some PSGI server don't provide a file handle for input and errors. They need to be tied to a file handle to be properly used.
|
Done. And also added the tie for the errors stream. |
|
Any news on this? |
miyagawa
added a commit
that referenced
this pull request
Sep 18, 2013
Use tied file handle for STDIN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PSGI server don't provide a file handle for input and errors.
They need to be tied to a file handle to be properly used.