Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalina support #91

Merged
merged 5 commits into from
Nov 26, 2019
Merged

Catalina support #91

merged 5 commits into from
Nov 26, 2019

Conversation

tattali
Copy link
Contributor

@tattali tattali commented Oct 27, 2019

No description provided.

@tattali
Copy link
Contributor Author

tattali commented Oct 27, 2019

Sorry for these big changes but QLMarkdown is finally working with catalina #89

QLMarkdown.qlgenerator.zip

$ mv QLMarkdown.qlgenerator ~/Library/QuickLook/QLMarkdown.qlgenerator
$ qlmanage -r

I will update the homebrew formula as soon the release is out!

@tattali
Copy link
Contributor Author

tattali commented Oct 29, 2019

It seems thats the quick look should be notarized with 99$ fee.
To prevent this you should :

$ open ~/Library/QuickLook/QLMarkdown.qlgenerator/Contents/MacOS/

right click open on the binary
then in the Preferences panel > go to Security & Privacy > and click on Allow QLMarkdown
then if needed re run qlmanage

qlmanage -r

If you find an other way please share it

@jspiro
Copy link

jspiro commented Nov 2, 2019

THANK YOU!

@tattali
Copy link
Contributor Author

tattali commented Nov 3, 2019

Inspired by this post, a process for this bundle could be:

Download QLMarkdown.qlgenerator.zip and unzip

$ mv ~/Downloads/QLMarkdown.qlgenerator ~/Library/QuickLook/QLMarkdown.qlgenerator
$ xattr -rd com.apple.quarantine  ~/Library/QuickLook/QLMarkdown.qlgenerator
$ qlmanage -r

try xattr without sudo, but you can use it if needed

Tell me if this process work fine to you, or if you need to use sudo or not, if you need to do extra work

Thanks

@Egwor
Copy link

Egwor commented Nov 9, 2019

Checked this out locally and built it fine. Ran it locally and it seemed to work ok.

image

The reason I'm here was that I saw the issue about the annoying 'malicious software' when I pulled the file down from brew). A faster fix is to run xattr -rd com.apple.quarantine QLMarkdown.qlgenerator from the ~/Library/QuickLook/ directory of course, but I was intrigued...
I, therefore, did a git clone, then pulled this PR down (via: git fetch origin pull/91/head:catalina-support for anyone wanting to copy this). I launched XCode and opened the project. I then built it fine (master didn't build). I ran Archive to get a distributable executable (although that seemed quite large at about 124K)

@janosh
Copy link

janosh commented Nov 25, 2019

Would be really helpful if this was merged.

@toland toland merged commit ae397c6 into toland:master Nov 26, 2019
@relikd relikd mentioned this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants