Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #1002

Closed
stepan662 opened this issue Mar 21, 2022 · 2 comments · Fixed by #1082
Closed

Dark mode #1002

stepan662 opened this issue Mar 21, 2022 · 2 comments · Fixed by #1082
Assignees
Projects

Comments

@stepan662
Copy link
Contributor

stepan662 commented Mar 21, 2022

Improve dark mode proposal
#997

@stepan662 stepan662 created this issue from a note in Development (Backlog) Mar 21, 2022
@cyyynthia
Copy link
Collaborator

I know this issue mostly targets the webapp more than the website, but it may be worth including revisiting slightly the website dark theme as well which has very low contrast ratio in certain places.

The brand color really doesn't play nice with a dark background: 2.8 contrast ratio, while the Web Content Accessibility Guidelines require a minimum contrast ratio of 4.5, and suggest a contrast ratio of 7 for enhanced contrast.

image

@JanCizmar
Copy link
Contributor

I know this issue mostly targets the webapp more than the website, but it may be worth including revisiting slightly the website dark theme as well which has very low contrast ratio in certain places.

It's now updated on the website!

@stepan662 stepan662 moved this from Backlog to In progress in Development Apr 20, 2022
@stepan662 stepan662 linked a pull request Apr 20, 2022 that will close this issue
Development automation moved this from In progress to Closed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants