Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tranlated/Untranslated percentage should be based on amount of keys translated. #2021

Closed
GeertZondervan opened this issue Dec 12, 2023 · 5 comments
Assignees
Labels

Comments

@GeertZondervan
Copy link
Contributor

GeertZondervan commented Dec 12, 2023

Currently the percentages that shows how much is translated/untranslated for a language is based on the word count.

              stats.apply {
                translatedKeys = rawLanguageStats.translatedKeys
                translatedWords = rawLanguageStats.translatedWords
                translatedPercentage = rawLanguageStats.translatedWords.toDouble() / baseWords * 100
                reviewedKeys = rawLanguageStats.reviewedKeys
                reviewedWords = rawLanguageStats.reviewedWords
                reviewedPercentage = rawLanguageStats.reviewedWords.toDouble() / baseWords * 100
                untranslatedKeys = projectStats.keyCount - translatedOrReviewedKeys
                this.untranslatedWords = baseWords - translatedOrReviewedWords
                untranslatedPercentage = untranslatedWords.toDouble() / baseWords * 100
              }

I think it would be better if this percentage was calculated based on the keys that have been translated. It gives a better view of the amount of work that needs to be done.

@GeertZondervan GeertZondervan changed the title Request: Tranlated/Untranslated percentage should be based on amount of keys translated. Tranlated/Untranslated percentage should be based on amount of keys translated. Dec 12, 2023
@JanCizmar
Copy link
Contributor

Hello! This should probably become an configuration option. From the translator point of view it makes more sense to count the words.

@JanCizmar JanCizmar self-assigned this Dec 13, 2023
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jan 13, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

@krisgerhard
Copy link

krisgerhard commented Apr 15, 2024

+1

@JanCizmar
Is it possible to convert it into a feature request or should we create new issue?

@JanCizmar
Copy link
Contributor

Fot this one, it would be better to create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants