Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Ruby YAML support #2183

Merged
merged 32 commits into from
Mar 26, 2024
Merged

feat: Add Ruby YAML support #2183

merged 32 commits into from
Mar 26, 2024

Conversation

JanCizmar
Copy link
Contributor

@JanCizmar JanCizmar commented Mar 13, 2024 •
edited

Tasks before ready:

  • When importing plural, the parameter should be converted to REPLACE_NUMBER (#)
  • Make XLIFF, JSON, and properties generic and accepting different placeholder types
  • Make import formats aligned with supported message formats for export, so it imports what's exported
  • Add Flat YAML format

@JanCizmar JanCizmar marked this pull request as draft March 13, 2024 10:24
@JanCizmar JanCizmar linked an issue Mar 13, 2024 that may be closed by this pull request
Support for YAML format (Ruby) #2160
Closed
4 tasks
This was referenced Mar 20, 2024
Closed
Closed
@JanCizmar
feat: Add Ruby YAML support
f04fe2c
@JanCizmar
feat: YAML format detection an importing in various formats
d51fe45
@JanCizmar
feat: YAML format detection an importing in various formats
fa7a89f
@JanCizmar
feat: WIP: Changing the imported format
bbde3c7
@JanCizmar
fix: Fixes after rebase
e8f2359
@JanCizmar
fix: Remove format setting stuff
0ffe10f
@JanCizmar
fix: Generalize import convertors & unit test fixes
aa06485
@JanCizmar
fix: schema
520a902
@JanCizmar
fix: Add test for placeholder conversion setting application
9b24a8c
@JanCizmar
fix: WIP yaml export, refactoring, missing: pluralsViaNesting handlin…
e31d507 
…g & tests
@JanCizmar
feat: Plural nesting works
d918b69
@JanCizmar
feat: Improve generic formats & refactoring
93ee4dd
@JanCizmar
feat: Improve generic formats & refactoring
3dce231
@JanCizmar
feat: Improve generic formats & refactoring
5b0bbc0
@JanCizmar
feat: Make XLIFF generic
8222f52
@JanCizmar
feat: Import format detection tests
3fa3b91
@JanCizmar
feat: Export message format respected for generic formats and tested
70811e8
@JanCizmar
feat: Plural arg conversion
1e1bd7f
@JanCizmar
chore: Generalize param convertors
1d97ca5
@JanCizmar
chore: Generalize param convertors
756e49a
@JanCizmar
fix: Get rid of rootKeyIsLanguageTag
c85ebf9
@JanCizmar
fix: Error handling & tests
8c41f61
@JanCizmar
fix: Make .po generic
9d85ed5
@JanCizmar
feat: MessageFormat Frontend
117cfba
@JanCizmar
fix: Final touch and e2e
6a59c30
@JanCizmar JanCizmar marked this pull request as ready for review March 26, 2024 10:38
@JanCizmar JanCizmar enabled auto-merge (squash) March 26, 2024 10:39
@JanCizmar JanCizmar merged commit 118ecf7 into main Mar 26, 2024
29 checks passed
@JanCizmar JanCizmar deleted the jancizmar/add-ruby-yaml branch March 26, 2024 10:48
TolgeeMachine pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): 3.54.0 [skip ci]
59bb099 
# [3.54.0](v3.53.1...v3.54.0) (2024-03-26)

### Features

* Add Ruby YAML support ([#2183](#2183)) ([118ecf7](118ecf7))
* improve routing and redirects ([#2210](#2210)) ([74aa4aa](74aa4aa))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 3.54.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepan662 stepan662 stepan662 approved these changes

Assignees
No one assigned
Labels
released on @latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for YAML format (Ruby)
2 participants
@JanCizmar @stepan662