Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

some minor fixes #28

Merged
merged 3 commits into from Nov 30, 2020
Merged

some minor fixes #28

merged 3 commits into from Nov 30, 2020

Conversation

jrappen
Copy link
Contributor

@jrappen jrappen commented Nov 30, 2020

  • change from js to diff code blocks in migration docs
  • readability English docs
  • add some links to references

@jrappen
Copy link
Contributor Author

jrappen commented Nov 30, 2020

⚠️ That workflow shouldn't attempt to deploy the docs built for testing. It naturally fails due to me not being authorized to push to your repo.

@tolking
Copy link
Owner

tolking commented Nov 30, 2020

⚠️ That workflow shouldn't attempt to deploy the docs built for testing. It naturally fails due to me not being authorized to push to your repo.

thanks, I also found this problem.

@tolking tolking merged commit a266e84 into tolking:master Nov 30, 2020
@jrappen
Copy link
Contributor Author

jrappen commented Nov 30, 2020

if you need help, let me know

@tolking
Copy link
Owner

tolking commented Nov 30, 2020

Welcome PR
Maybe:
PR -› test the build
push master -› build and deploy

@jrappen
Copy link
Contributor Author

jrappen commented Nov 30, 2020

Ok, I am busy now. Will give it a try later today.

@jrappen jrappen mentioned this pull request Mar 11, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrappen @tolking