Implement Trade API #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toloco Note that this requires changes to __call, as it strips all non-truthy arguments but update_trade explicitly requires values of 0 to remove some trade parameters. Passing 0 seems valid, and passing empty values (e.g. '') may also be desirable in some situations, so this seems like a I'm also not sure what sort of validation I should be doing on arguments coming in (e.g. maxId and count should always be things that will convert to an integer value); I've left them alone as they'll eventually return an API error if they're not valid, but we could be more proactive and immediately return an error when we get values that we know won't work. |
elyobo
force-pushed
the
implement-trades
branch
2 times, most recently
from
df6b7cb
to
3db1918
Compare
Note that this requires changes to __call, as it strips all non-truthy arguments but update_trade explicitly requires values of 0 to remove some trade parameters. Passing 0 seems valid, and passing empty values (e.g. '') may also be desirable in some situations, so this seems like a safe change.
elyobo
force-pushed
the
implement-trades
branch
from
3db1918
to
7b15d61
Compare
Closed
|
Implements #2 |
|
Good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.