Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retrieving full transaction history. #24

Merged
merged 1 commit into from
Aug 19, 2015

Conversation

elyobo
Copy link
Contributor

@elyobo elyobo commented Aug 11, 2015

When requesting full transaction history, the Oanda API only provides a
url to the location that the history will eventually be available at.
This provides a method for polling the location until it's available,
then downloading the file, processing the content of the ZIP and
extracting the result.

Note that this cannot be tested in the sandbox, as it doesn't return a
valid URL for the transaction history.

@landscape-bot
Copy link

Code Health
Repository health decreased by 1% when pulling 6d5bfd0 on elyobo:transaction-history-download into f786861 on toloco:develop.

When requesting full transaction history, the Oanda API only provides a
url to the location that the history will eventually be available at.
This provides a method for polling the location until it's available,
then downloading the file, processing the content of the ZIP and
extracting the result.

Note that this cannot be tested in the sandbox, as it doesn't return a
valid URL for the transaction history.
@elyobo elyobo force-pushed the transaction-history-download branch from 6d5bfd0 to 1b9d702 Compare August 13, 2015 04:32
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 1b9d702 on elyobo:transaction-history-download into f786861 on toloco:develop.

toloco added a commit that referenced this pull request Aug 19, 2015
Support retrieving full transaction history.
@toloco toloco merged commit 95ca90f into toloco:develop Aug 19, 2015
@elyobo elyobo deleted the transaction-history-download branch August 20, 2015 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants