-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed initial logging, and added a functional example #33
Conversation
Can you check why travis says no? it looks like something it is wrong in the code. Thanks, |
|
||
log = getLogger(__name__) | ||
|
||
logging.basicConfig(level='CRITICAL') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you are defining a logger instead of getting the defined logger, we should use this approach in case of global logger doesn't exists.
As we can see below logging.basicConfig actually initialises the logging features, which removes a warning message when using Python 2.x
https://docs.python.org/2/library/logging.html#logging.basicConfig |
Thanks mate, it looks much better. Just one very little think, can you make sure it is compliant of PEP8 too? let me know if this is too annoying... |
Hey, I don't have a PEP8 verification method. Perhaps you know of one? |
Yay! Thanks, |
@tavurth thanks for your contribution |
Hi I fixed a logging error "No logger available for pyoanda", and changed the data grabbing example to be more useful (With comments)