Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

_cap_cup should never set _eol to True` #76

Closed
eugulixes opened this issue Feb 23, 2017 · 2 comments
Closed

_cap_cup should never set _eol to True` #76

eugulixes opened this issue Feb 23, 2017 · 2 comments
Projects

Comments

@eugulixes
Copy link
Contributor

Such programs like vi may send something like \E[23;80H (set the vertical and horizontal positions of the cursor to y and x). The current implementation of cup will set _eol to True in this case and _echo will write a character on the next line. It's obviously a bug.

@eugulixes eugulixes added this to v0.4 in roadmap Feb 23, 2017
eugulixes added a commit that referenced this issue Feb 23, 2017
@dshil
Copy link
Contributor

dshil commented Feb 28, 2017

@eugulixes, but if the cursor is at the end of a line, where _echo should write a character?

@dshil dshil moved this from v0.4 to check in roadmap Feb 28, 2017
@eugulixes
Copy link
Contributor Author

@dshil, in my previous example the x and y values start from 1, so echo will put a character at the 80th position and then set _eol to True.

eugulixes added a commit that referenced this issue Mar 1, 2017
eugulixes added a commit that referenced this issue Mar 1, 2017
dshil pushed a commit that referenced this issue Mar 4, 2017
eugulixes added a commit that referenced this issue Mar 5, 2017
@dshil dshil closed this as completed in da730e9 Mar 7, 2017
@dshil dshil moved this from check to done in roadmap Mar 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

No branches or pull requests

2 participants