Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop minSdkVersion back to 16 or whatever is set in android/build.gradle #220

Closed
rodperottoni opened this issue May 15, 2019 · 4 comments
Closed

Comments

@rodperottoni
Copy link

rodperottoni commented May 15, 2019

According to the new Places SDK migration guide, Android phones with SDKs as low as 16 are still supported.
This change will negatively impact apps used everywhere in the planet, but particularly in third-world countries where the purchase power is lower (meaning the percentage of users with outdated Android phones is significantly higher). In one of our apps available in Australia (one of the countries with the highest purchase power in the planet) we still have ~2k users on Android 16-21, so I imagine this figure would be even higher somewhere else.
I'm wondering if you'd be considering accepting a PR to lower the minSdkVersion back to 16?

Thank you.

@aforty
Copy link
Contributor

aforty commented May 16, 2019

Same, wondering why this is necessary. I prefer to keep the minSdkVersion as low as possible.

@tolu360
Copy link
Owner

tolu360 commented May 16, 2019

Hi @rodperottoni, I have been super busy lately but would take another look at the build setup - I cannot recall exactly why I bumped it at the time but something must have been failing in the build process. So I live in Lagos myself so I understand your take on the number of users on SDK 21 and below. If I go as low as 16 and everything looks fine, I would be move it all the way back - otherwise I may stay on 19. I believe you have ran builds with SDK 16 already, yes?

Anyway, thanks for chiming in on this. Cheers!

@tolu360
Copy link
Owner

tolu360 commented May 17, 2019

So heads up, minSdkVersion is back to 16 or whatever a user sets for their project. I just tagged 3.0.1 release, ensure you pull that in and update your app. Cheers!

@tolu360 tolu360 closed this as completed May 17, 2019
@tolu360 tolu360 changed the title Bumped to minSdkVersion 21 - couldn't find any reason as to why? Drop minSdkVersion back to 16 or whatever is set in android/build.gradle May 17, 2019
@tolu360 tolu360 pinned this issue May 17, 2019
@rodperottoni
Copy link
Author

Really appreciate your work @tolu360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants