Simplify project collection usage

src/.editorconfig

@@ -157,3 +157,6 @@ dotnet_analyzer_diagnostic.severity = error
 
 # CA1305: Specify IFormatProvider
 dotnet_diagnostic.CA1305.severity = suggestion
+
+# VSSpell001: Spell Check
+dotnet_diagnostic.VSSpell001.severity = suggestion

src/LicenseGenerator/Builder.cs

@@ -30,7 +30,7 @@ internal sealed class Builder : IDisposable
     private readonly bool _offline;
     private readonly string _solutionDirectory;
     private readonly Regex? _excludeRegex;
-    private readonly Dictionary<NuGetFramework, TargetFrameworkCollection> _targetFrameworkCollections = new();
+    private readonly ProjectCollection _projectCollection = new();
     private readonly string _solutionFile;
 
     private ProjectInfo[] _projects = Array.Empty<ProjectInfo>();
@@ -58,7 +58,7 @@ public async Task<int> Build()
 
         var solution = SolutionFile.Parse(_solutionFile);
 
-        _projects = LoadProjects(solution, _targetFrameworkCollections)
+        _projects = LoadProjects(solution)
             .ExceptNullItems()
             .ToArray();
 
@@ -336,7 +336,7 @@ private async Task<string> CreateLicenseFile(IEnumerable<PackageArchiveReader> p
                         var lines = stream.ReadLines().ToArray();
                         if (lines.FirstOrDefault()?.Contains("MIT License") == true)
                         {
-                            content.AppendLine("License: MIT");
+                            content.AppendLine(MitLicenseExpression);
                         }
                         else if (lines.Any(ExtensionMethods.IsApache2License))
                         {
@@ -436,7 +436,7 @@ private bool ShouldInclude(ProjectInfo projectInfo)
         return bool.TryParse(property?.EvaluatedValue, out var include) && include;
     }
 
-    private static IEnumerable<ProjectInfo?> LoadProjects(SolutionFile solution, Dictionary<NuGetFramework, TargetFrameworkCollection> targetFrameworkCollections)
+    private IEnumerable<ProjectInfo?> LoadProjects(SolutionFile solution)
     {
         foreach (var projectReference in solution.ProjectsInOrder)
         {
@@ -451,7 +451,7 @@ private bool ShouldInclude(ProjectInfo projectInfo)
 
                 var project = new Project(projectReference.AbsolutePath);
 
-                projectInfo = new ProjectInfo(projectReference, project, GetTargetFrameworks(project), targetFrameworkCollections);
+                projectInfo = new ProjectInfo(projectReference, project, GetTargetFrameworks(project), _projectCollection);
             }
             catch (Exception ex)
             {
@@ -477,7 +477,7 @@ private static NuGetFramework[] GetTargetFrameworks(Project project)
         return frameworks ?? new[] { NuGetFramework.AnyFramework };
     }
 
-    private sealed record ProjectInfo(ProjectInSolution ProjectReference, Project Project, NuGetFramework[] TargetFrameworks, Dictionary<NuGetFramework, TargetFrameworkCollection> TargetFrameworkCollections)
+    private sealed record ProjectInfo(ProjectInSolution ProjectReference, Project Project, NuGetFramework[] TargetFrameworks, ProjectCollection ProjectCollection)
     {
         public IEnumerable<FrameworkSpecificProject> GetFrameworkSpecificProjects()
         {
@@ -493,9 +493,12 @@ private FrameworkSpecificProject GetProjectInFramework(NuGetFramework targetFram
             if (bestMatching == null)
                 return new FrameworkSpecificProject(Project, TargetFrameworks.FirstOrDefault() ?? NuGetFramework.AnyFramework);
 
-            var collection = TargetFrameworkCollections.ForceValue(bestMatching, framework => new TargetFrameworkCollection(framework));
+            var properties = new Dictionary<string, string>
+            {
+                { "TargetFramework", targetFramework.GetShortFolderName() }
+            };
 
-            return new FrameworkSpecificProject(collection.LoadProject(ProjectReference.AbsolutePath), bestMatching);
+            return new FrameworkSpecificProject(ProjectCollection.LoadProject(ProjectReference.AbsolutePath, properties, null), bestMatching);
         }
     }
 
@@ -506,31 +509,6 @@ private sealed record FrameworkSpecificProject(Project Project, NuGetFramework T
         public LockFile LockFile => _lockFile ??= LockFileUtilities.GetLockFile(Project.GetPropertyValue("ProjectAssetsFile"), NullLogger.Instance);
     }
 
-    private sealed class TargetFrameworkCollection : IDisposable
-    {
-        private readonly ProjectCollection _projectCollection;
-
-        public TargetFrameworkCollection(NuGetFramework framework)
-        {
-            var properties = new Dictionary<string, string>
-            {
-                { "TargetFramework", framework.GetShortFolderName() }
-            };
-
-            _projectCollection = new ProjectCollection(properties);
-        }
-
-        public Project LoadProject(string filePath)
-        {
-            return _projectCollection.LoadProject(filePath);
-        }
-
-        public void Dispose()
-        {
-            _projectCollection.Dispose();
-        }
-    }
-
     private static async Task<ICollection<string>> DownloadLicense(string url)
     {
         try
@@ -546,9 +524,6 @@ private static async Task<ICollection<string>> DownloadLicense(string url)
 
     public void Dispose()
     {
-        foreach (var collection in _targetFrameworkCollections.Values)
-        {
-            collection.Dispose();
-        }
+        _projectCollection.Dispose();
     }
 }

src/LicenseGenerator/Constants.cs

@@ -1,6 +1,7 @@
 internal static class Constants
 {
     public const string IsDeploymentTarget = "IsDeploymentTarget";
+    public const string MitLicenseExpression = "License: MIT";
     public const string ApacheLicenseExpression = "License: Apache-2.0";
     public const string ApacheLicenseUrl = "http://www.apache.org/licenses/LICENSE-2.0";
     public const string MicrosoftNetLibraryLicenseExpression = "License: MICROSOFT .NET LIBRARY (http://go.microsoft.com/fwlink/?LinkId=329770)";