Some questions on the app-of-apps structure

[Analect]

@tom333 ... I came across your repo from your mentioning it here. Thanks for your work on this.

I had been interested in how an argocd app-of-apps pattern might work for Kubeflow, so I'm glad I have some reference now. Can I ask, was it necessary to bring across all the underlying component manifests under manifests/apps to your own repo ... could argocd not be set up to reference the source manifests back here? ... where maybe you could control the upstream by fixing to a particular release ... such as: https://github.com/kubeflow/manifests/blob/v1.6.1/apps/jupyter/jupyter-web-app/upstream/base/deployment.yaml

Is there an advantage to having it all in your own repo?
Also, I'm no expert on ArgoCD, but was there a reason to bundle these elements together ... are they the core building blocks on which the other components are built? I presume their ordering is important?

Was there any particular reason you disabled katib here?

If I've installed argocd with ...

kubectl create namespace argocd
kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/stable/manifests/install.yaml

... how might one handle the pre-requisite ref. the kustomization version here? .. or is it best to use helm for installing argocd?

I'm testing this on a local k3d cluster. Should I disable traefik and use istio per your other pre-requisite here. If I'm not mistaken, istio gets installed as part of kubeflow, right?

Thanks for any pointers you can offer.

[tom333]

Hi,

Sorry for the delay I'll try to answer each question:

• as I mention in the header of the README file, "Manifest are copied here, waiting migration on kustomize 4 with remote resources : Upgrade to use Kustomize v4+ kubeflow/manifests#1797 Or waiting for Proposal: support multiple sources for an Application argoproj/argo-cd#677 for removing local kustomization files"
  Maybe there is a better way to do the same

• Bundles are purely opinionated. Actually, this is core tools on which kubeflow run, so I think it make sense to bundle them together.

• Of course, I could have put everything in one only app.

• Katib is disable because I don't use yet but is easy to enable

• I prefer helm for installing argocd, but you don't have to use it. You can install it with only manifest

• On my k3s cluster, I have both traefik and istio installed, and it works like a charm