-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation issue #45
Conversation
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 74.50% 74.50%
=======================================
Files 43 43
Lines 2593 2593
=======================================
Hits 1932 1932
Misses 661 661
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
removing setup.py ???
… |
We can keep it, however it was already empty. I did not completely read PEP517/518, but from alphacsc/alphacsc#47 I understand that removing setup.py complies with the conventions.
|
I use setup.py files for all my projects but I am open to anything that
works.
I still see people do things like:
python setup.py install
or
python setup.py develop
|
We can keep the file if you prefer so. I just removed considering PEP conventions and as it didn't contain any specific code. The problem is fixed even if setup.py is there, I just needed to remove the imports. |
This reverts commit 259f87e.
I think we cannot remove the |
I do not have a clear idea why installation started to give error, but this fixes the issue.
This will also make CI pass for #42 and #44.