Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation issue #45

Merged
merged 4 commits into from
Oct 9, 2021
Merged

Conversation

hndgzkn
Copy link
Collaborator

@hndgzkn hndgzkn commented Oct 8, 2021

I do not have a clear idea why installation started to give error, but this fixes the issue.

This will also make CI pass for #42 and #44.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #45 (c567862) into main (ad30e87) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   74.50%   74.50%           
=======================================
  Files          43       43           
  Lines        2593     2593           
=======================================
  Hits         1932     1932           
  Misses        661      661           
Flag Coverage Δ
unittests 74.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad30e87...c567862. Read the comment docs.

@agramfort
Copy link
Collaborator

agramfort commented Oct 8, 2021 via email

@hndgzkn
Copy link
Collaborator Author

hndgzkn commented Oct 8, 2021

We can keep it, however it was already empty. I did not completely read PEP517/518, but from alphacsc/alphacsc#47 I understand that removing setup.py complies with the conventions.

removing setup.py ???

@agramfort
Copy link
Collaborator

agramfort commented Oct 8, 2021 via email

@hndgzkn
Copy link
Collaborator Author

hndgzkn commented Oct 8, 2021

We can keep the file if you prefer so. I just removed considering PEP conventions and as it didn't contain any specific code.

The problem is fixed even if setup.py is there, I just needed to remove the imports.

@tomMoral
Copy link
Owner

tomMoral commented Oct 9, 2021

I think we cannot remove the setup.py because else the pip install -e . does not work anymore?
I also updated the sphinx-version as done by @hndgzkn in alphacsc/alphacsc#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants