* Prevent race condition.

(cherry picked from commit ebbedb2)
tomahawk-player · Mar 30, 2012 · ace18df · ace18df
1 parent 95f1162
commit ace18df
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/src/libtomahawk/database/databasecommand_resolve.cpp b/src/libtomahawk/database/databasecommand_resolve.cpp
@@ -143,8 +143,9 @@ DatabaseCommand_Resolve::resolve( DatabaseImpl* lib )
             url = QString( "servent://%1\t%2" ).arg( s->userName() ).arg( url );
         }
 
+        bool cached = Tomahawk::Result::isCached( url );
         Tomahawk::result_ptr result = Tomahawk::Result::get( url );
-        if ( result->isValid() )
+        if ( cached )
         {
             qDebug() << "Result already cached:" << result->toString();
             res << result;
@@ -281,8 +282,9 @@ DatabaseCommand_Resolve::fullTextResolve( DatabaseImpl* lib )
             url = QString( "servent://%1\t%2" ).arg( s->userName() ).arg( url );
         }
 
+        bool cached = Tomahawk::Result::isCached( url );
         Tomahawk::result_ptr result = Tomahawk::Result::get( url );
-        if ( result->isValid() )
+        if ( cached )
         {
             qDebug() << "Result already cached:" << result->toString();
             res << result;

diff --git a/src/libtomahawk/result.cpp b/src/libtomahawk/result.cpp
@@ -50,6 +50,14 @@ Result::get( const QString& url )
 }
 
 
+bool
+Result::isCached( const QString& url )
+{
+    QMutexLocker lock( &s_mutex );
+    return ( s_results.contains( url ) );
+}
+
+
 Result::Result( const QString& url )
     : QObject()
     , m_url( url )
@@ -86,13 +94,6 @@ Result::deleteLater()
 }
 
 
-bool
-Result::isValid() const
-{
-    return !m_rid.isEmpty();
-}
-
-
 artist_ptr
 Result::artist() const
 {

diff --git a/src/libtomahawk/result.h b/src/libtomahawk/result.h
@@ -56,9 +56,9 @@ friend class ::DatabaseCommand_LoadFile;
 
 public:
     static Tomahawk::result_ptr get( const QString& url );
+    static bool isCached( const QString& url );
     virtual ~Result();
 
-    bool isValid() const;
     QVariant toVariant() const;
     QString toString() const;
     Tomahawk::query_ptr toQuery();