Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albums need to support Local Collection as a metadata/track listing source #443

Open
scubbx opened this issue Feb 18, 2016 · 6 comments
Open
Assignees
Milestone

Comments

@scubbx
Copy link

scubbx commented Feb 18, 2016

With my Japanese Soundtracks, some Titles are not recognized, despite being loaded into the library.
This screenshot shows the problem (all Files exist locally):

git_issue_tomahawk

The filename as well as the tags are using roman fonts, not Japanes. For whatever reason, Tomahawk decides to look up the metadata of this album from somewhere else and use the Japanese writing. Following this, the file is not found. If I change the tag to exactly contain the Japanese letters a shown by Tomahawk, the file is found again (e.g. the second entry on my screenshot). If I change the title to Japanese letters, but include the title with roman letters in parentheses alongside, the track is not found (third entry in my screenshot).

@muesli
Copy link
Member

muesli commented Feb 18, 2016

Thanks for the report! We're aware of the situation. The idea behind it is, that Tomahawk fetches the album's track listing from MusicBrainz and then tries to resolve the list against all your available sources - e.g. not only local files, but also Soundcloud, Spotify & co. We realized this is a bit frustrating for some users and will improve this situation with the next release. Stay tuned! :-)

@scubbx
Copy link
Author

scubbx commented Feb 18, 2016

Funny thing is, I used MusicBrainz Picard to correct the tags on this album - but if there is more than one result and the others are in a different language, this becomes complicated.
Well, a good reason to learn some Japanese signs/words. :-D

@muesli muesli self-assigned this Feb 23, 2016
@muesli muesli added this to the 0.9 milestone Feb 23, 2016
@muesli muesli changed the title Local file not detected (Japanese Title) Albums need to support Local Collection as a metadata/track listing source Apr 13, 2016
@asibs
Copy link

asibs commented Jun 18, 2016

I think the situation is actually worse than this - I have locally stored albums that are not available online. I can't play them through the Albums view at all - I just get an error saying no tracks found, even though they are all there locally (and I can play them through the artist->album->song view, and the song view).

@dschmidt
Copy link
Member

@muesli is/was kinda working on this. Any update here?

@R-Broadley
Copy link

R-Broadley commented Jul 23, 2016

I also have this problem.
My collection is mostly FLAC files with Voribis tags all generated using Musicbrainz which I worked hard to ensure is correct.
The files contain various ID tags including acoustic ID and Musicbrainz release ID, artist ID, album-artist ID and track ID.

I suggest four solutions:

  1. Where Musicbrainz IDs are included in the file tags these are used to identify the correct version.
  2. Where the above is not possible maybe try an acoustic ID which could be generated where necessary.
  3. If IDs fail, more flexible lookup is needed as where tracks have featured artists in either the title or artist tag tomahawk fails to associate the track with the album. Perhaps the album tag should play a greater role.
  4. As a last resort if a match for the album cannot be found i.e it's not widely available, the local tags should be used and maybe add (local) to the album title in tomahawk.

The software should also allow user correction to link a local file to track on an album for when all the above fails.

@jucor
Copy link

jucor commented Sep 2, 2016

Same problem for me. Any idea when 0.9 with the fix will be available, please? Sadly it's a deal breaker for my wife who has tons of songs with titles in French and Rom full of accents, that just fail to be played by Tomahawk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants